Disable chromium metrics providers #26294
Open
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
changed the title
|
A test build to check crash reporting: https://ci.brave.com/job/test-brave-browser-build-macos-arm64/713/ |
iefremov
reviewed
Nov 5, 2024
| // This object is created by the metrics service before threads, but it | ||
| // needs the UserPerformanceTuningManager to exist. At this point it's | ||
| // instantiated, but still needs to be initialized. | ||
| performance_manager::MetricsProviderDesktop::GetInstance()->Initialize(); |
There was a problem hiding this comment.
can we chromium_src MetricsProviderDesktop to make Initialize() a noop, instead of this patch?
There was a problem hiding this comment.
The issue is GetInstance() == nullptr, not with Initialize().
We can try to use chromium_src for this file to replace MetricsProviderDesktop to someFake MetricsProviderDesktop
iefremov
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For brave/brave-browser#41947
Chromium collects a lot of metrics to send via UMA/UKM.
We don't need them, because we don't send them anyway.
Disabling this helps to save some CPU and memory.
TODO:
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: