Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Notes for iOS Release 1.74 #43405

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

Uni-verse
Copy link
Contributor

Resolves #43403

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ for web3

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but generally looks good 👍 However, you're missing #43183 re: the C132 addition which needs to be added at the bottom.

CHANGELOG_iOS.md Outdated Show resolved Hide resolved
CHANGELOG_iOS.md Outdated Show resolved Hide resolved
@Uni-verse
Copy link
Contributor Author

Some small nits but generally looks good 👍 However, you're missing #43183 re: the C132 addition which needs to be added at the bottom.

Oh yes.. good catch, thanks.

@Uni-verse Uni-verse requested a review from kjozwiak January 27, 2025 22:45
@Uni-verse
Copy link
Contributor Author

Thanks for reviewing guys, changes are in - acbf247

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice work sir.

@Uni-verse Uni-verse merged commit 7ccb58b into master Jan 28, 2025
4 checks passed
@Uni-verse Uni-verse deleted the smesher-ios-release-notes-1.74 branch January 28, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Notes for iOS Release 1.74.x
3 participants