define acceptable node versions, and enforce at install time

[pes10k]

Simple change that

1. defines allowed node versions in package.json
2. enforce this in.npmrc

Resolves #42911

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A
  • https://github.com/brave/brave-browser/wiki/Brave-Wallet

Test Plan:

[fallaciousreasoning]

Probably doesn't hurt having this but the recommended build instructions are to checkout brave-core now, so this should be caught during init

Additionally, we should be careful not to let these get out of sync 😆

[pes10k]

ah, gotcha gotcha! Two suggestions then

1. maybe it'd be good to also force the version check with a .npmrc in brave-core then too?
2. making sure things don't fall out of sync sounds very good ha :) the wiki/README/other documentation already needs to stay in sync with brave-core's package.json though. I dont know where the "one true" definition should be but, just noting that things already need to stay in sync, and so maybe it can all be hoisted into one central location? WDYT?

[goodov]

doesn't look like version should be changed here.

[pes10k]

ah, not sure what happened there, but fixed!

[pes10k]

@goodov just pinging on this, is there anything further needed from me on this?

[goodov]

@goodov just pinging on this, is there anything further needed from me on this?

I don't think so. feel free to merge!

[pes10k]

thanks! but no can do yet, i think i still need another approval from @brave/devops-team 🤔

[pes10k]

thanks to ya both!