-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated issue templates #38286
Updated issue templates #38286
Conversation
This is intended for code health situations (Fixups for pull request, refactorings, etc) May need to make this a .yml - but wanted to try and see what happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tried it out and it's very nice
Would be cool to have a |
@iccub I'd like to merge this without further delay, so I'm going to go ahead now. Please feel free to open a new PR for this. The change would consist of adding a file like |
hey @wknapik wouldn't be good to add a specific Technically any filter list related issues should be in The thing is that Brave depends mostly on other lists, so the issues that might happen because of Brave specific/made rules are minimal as well, but people might report them to brave anyway, when 3rd party default lists should be reported to the respective filter list repository/group that is causing the issue like Easylist or uAssets, or could be just a rule that will be updated/added by those groups later and Brave doesn't need to do anything and just wait for it like happens with youtube, although I know FanboyNZ/ryanbr might add it to Easylist, so reporting it from Community Brave can help to improve Easylist. But also issues might be a custom rule/list that people added or accidentally created themselves. If anything, there is also Brave's I mean, look at the template made by uBlock people https://github.com/uBlockOrigin/uAssets/issues/new?assignees=&labels=&projects=&template=bug_report.yml just to try to avoid useless reports, this is because adblocking depends on so much that it needs really specific stuff to make sure it is a specific uBlock issue and not just random little big in a page or an extension causing it. |
Thanks for the comment @TEMP-ad. We'll have think about how we'd like our adblocking template to look and probably add one in the near future. |
Everything can be adjusted, feel free to push to this PR branch, or request changes in comments
This can be tested at https://github.com/brave-experiments/wknapik-test-02/issues/new/choose