Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more development docs #35364

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Add more development docs #35364

merged 1 commit into from
Jan 17, 2024

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 16, 2024

Fix #35354

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@diracdeltas diracdeltas requested a review from bbondy January 16, 2024 23:46
@diracdeltas diracdeltas self-assigned this Jan 16, 2024
@diracdeltas diracdeltas requested a review from a team as a code owner January 16, 2024 23:46
@diracdeltas diracdeltas enabled auto-merge January 16, 2024 23:47
@diracdeltas diracdeltas merged commit da11ca5 into master Jan 17, 2024
5 checks passed
@diracdeltas diracdeltas deleted the fix/35354 branch January 17, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some more security links to development readme
2 participants