Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brave://path to support deep linking to Search Engine edit popup in settings #42999

Closed
6 tasks
bradleyrichter opened this issue Dec 19, 2024 · 6 comments · Fixed by brave/brave-core#27223
Closed
6 tasks
Assignees
Labels
feature/search OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone

Comments

@bradleyrichter
Copy link

Description

In order to open the proper dialog allowing users to change their default search engine, we need to add a deep link path to the settings popup.

This change is dependent on this issue which will allow for targeting the correct popup depending on normal or private settings.

#42990

Steps to reproduce

try to use the path: brave://settings/search

notice it doesn't open the popup behind the Change button

Actual result

no path to open sub dialog

Expected result

link available to this page:

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

all versions

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@tmancey
Copy link
Contributor

tmancey commented Jan 15, 2025

cc @tmancey so I can follow this issue. Thanks

@kjozwiak
Copy link
Member

Added QA/Test-All-Platforms after discussing the above with @LaurenWags. We should check/ensure the above is working on all platforms as we want to ensure that deep linking is working as expected.

@kjozwiak
Copy link
Member

The above requires 1.75.165 or higher for 1.75.x verification 👍

@btlechowski
Copy link

After talking to @tmancey, I removed the feature/ads label as this is not an ads issue.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 23, 2025

Verification PASSED using

Brave | 1.75.166 Chromium: 132.0.6834.111 (Official Build) beta (64-bit)
-- | --
Revision | 0c5da0a4df158be9400ac84df9312b627cc4dec0
OS | Windows 11 Version 24H2 (Build 26100.26
Case 1: Normal window - PASSED
  1. Installed 1.75.166
  2. launched Brave
  3. opened brave://settings/search
  4. verified search engine page shown Brave as a default for both Normal & Private windows as expected
  5. clicked Change button for Normal window
  6. confirmed default search dialog is shown with Brave as default
  7. confirmed URL bar shows brave://settings/search/defaultSearch
  8. selected Startpage and clicked Cancel
  9. confirmed the dialog dismissed and the browser automatically navigated to brave://settings/search
  10. clicked Change button again
  11. selected Startpage and clicked Set as default
  12. confirmed the dialog dismissed and the browser automatically navigated to brave://settings/search
  13. confirmed Startpage shown as default
  14. opened a new tab page
  15. Search Startpage ... placeholder text is shown in the URL bar
  16. entered a search term London in the URL bar
  17. confirmed Starpage search results are shown
step 4-5 step 6-7 step 8 step 9 step 10-11 step 12-13 step 15 step 16
Image Image Image Image Image Image Image Image
Case 2: Private Window - PASSED
  1. New profile
  2. opened brave://settins/search in a new tab
  3. verified search engine page shown Brave as a default for both Normal & Private windows as expected
  4. clicked Change button for Private window
  5. confirmed default search dialog is shown with Brave as default for Private window
  6. confirmed URL bar shows brave://settings/search/privateSearch
  7. selected DuckDuckGo and clicked Cancel
  8. confirmed the dialog dismissed and the browser automatically navigated to brave://settings/search
  9. clicked Change button again
  10. selected DuckDuckGo and clicked Set as default
  11. confirmed the dialog dismissed and the browser automatically navigated to brave://settings/search
  12. confirmed DuckDuckGo shown as default for Private window
  13. opened a Private window via hamburger menu
  14. Search DuckDuckGo... placeholder text is shown in the URL bar
  15. entered a search term London in the URL bar
  16. confirmed DuckDuckGo search results are shown
step 3-4 step 5-6 step 7 step 8 step 10 step 11-12 step 14 step 16
Image Image Image Image Image Image Image Image
Case 3: Upgrade - PASSED
  1. Installed 1.74.50
  2. launched Brave
  3. opened brave://settings/search in a new tab
  4. verified Brave is shown as a default and Change button is shown for Normal window
  5. verified Brave is shown as a default and dropdown is shown for Private window
  6. clicked Change button for Normal window
  7. confirmed default search dialog is shown with Brave as default but the URL bar shows brave://settings/search/search
  8. closed Brave
  9. renamed the profile `Brave-Browser-Beta
  10. installed 1.75.166
  11. launched Brave
  12. navigated to brave://settings/search
  13. confirmed Change button is shown for both Normal & Private windows in the Search engine edit dialog
  14. clicked Change for Normal window
  15. confirmed default search dialog is shown with Brave as default
  16. confirmed URL bar shows brave://settings/search/defaultSearch
  17. confirmed able to set Google as a new default
  18. confirmed the dialog dismissed and the browser automatically navigated to brave://settings/search
  19. repeated steps 14-18 for Private window and results shown as expected
step 4-5 step 7 step 13 step 15-16 step 17 step 18 step 19
Image Image Image Image Image
Image Image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 23, 2025
@MadhaviSeelam
Copy link

Verification In progress using

Brave | 1.75.164 Chromium: 132.0.6834.83 (Official Build) beta (arm64)
-- | --
Revision | befbba8d7568f8713d6f942f9a7350c59b57f20a
OS | macOS Version 15.2 (Build 24C101)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/search OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

8 participants