Move Shipping Callback URL to PayPalCheckoutRequest
#1200
Conversation
| shippingCallbackUrl?.let { | ||
| if (it.toString().isNotEmpty()) parameters.put(SHIPPING_CALLBACK_URL_KEY, it) | ||
| } |
There was a problem hiding this comment.
Should this logic move into PayPalCheckoutRequest?
There was a problem hiding this comment.
Logic is already there
My mistake was approaching this change differently in iOS. In iOS, I created the feature branch from scratch, while here, I only removed shippingCallbackUrl from the Vault flow, keeping the changes from the PR previously merged into this feature branch.
There was a problem hiding this comment.
Ah gotcha, no worries! Thanks for pointing out where it was since the approach was slightly different.
| @@ -301,57 +299,4 @@ public void createRequestBody_sets_userPhoneNumber_when_not_null() throws JSONEx | |||
|
|
|||
| assertTrue(requestBody.contains("\"phone_number\":{\"country_code\":\"1\",\"national_number\":\"1231231234\"}")); | |||
| } | |||
|
|
|||
| @Test | |||
| public void createRequestBody_sets_shippingCallbackUri_when_not_null() throws JSONException { | |||
There was a problem hiding this comment.
Are we able to add these tests to PayPalCheckoutRequestUnitTest?
There was a problem hiding this comment.
Yes, there are already 3 unit tests that cover this in PayPalCheckoutRequestUnitTest
Summary of changes
shippingCallbackUrlparameter toPayPalCheckoutRequestto limit it to checkout flows. Shipping callbacks should only be available for PayPal checkout flows.Checklist
Authors