Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API where getParcelableExtra method is used #1197

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Update API where getParcelableExtra method is used #1197

merged 4 commits into from
Oct 29, 2024

Conversation

saperi22
Copy link
Contributor

@saperi22 saperi22 commented Oct 28, 2024

Summary of changes

  • Fixing a crash caused by a call to Intent.getParcelableExtra on API 33.
  • Suggestion on Google Issue Tracker is to use older APIs for 33 to avoid the crash.

Checklist

  • Added a changelog entry
  • Relevant test coverage

Authors

@saperi22

@saperi22 saperi22 marked this pull request as ready for review October 29, 2024 18:06
@saperi22 saperi22 requested a review from a team as a code owner October 29, 2024 18:06
CHANGELOG.md Outdated
@@ -2,6 +2,8 @@

## unreleased

* GooglePay
* Fixing a crash on API 33 devices. It is recommended that merchants not use 5.1.0 for GooglePay.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this issue specific to 5.1.0 or would it also be 5.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was introduced in 5.1.0. See the diff 5.0.0...5.1.0 below for refs.

Screenshot 2024-10-29 at 1 16 05 PM

@saperi22 saperi22 merged commit 7a7124e into main Oct 29, 2024
3 checks passed
@saperi22 saperi22 deleted the fix-crash branch October 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants