Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App link setup docs #1171

Merged
merged 4 commits into from
Oct 1, 2024
Merged

App link setup docs #1171

merged 4 commits into from
Oct 1, 2024

Conversation

sarahkoop
Copy link
Contributor

Summary of changes

  • Add guide for setting up app links since it is now required for the PayPal flow.

Checklist

  • [ ] Added a changelog entry
  • [ ] Relevant test coverage

Authors

@sarahkoop

@sarahkoop sarahkoop requested a review from a team as a code owner September 27, 2024 15:22
@@ -386,7 +386,7 @@ before the `OnResume` method of your Activity or Fragment.
do not need to be instantiated in `OnCreate`.

The PayPal integration now requires an Android App link be configured to return to your app from the
PayPal flow.
PayPal flow. See the [App Link Setup Guide](APP_LINK_SETUP.md) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of linking to a new markdown file do we want to link to the dev docs for app switch? I know they are currently under the v4 section which we call out, but could update to the v5 links once the docs are updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed a little confusing to link directly to those since they reference app switch and app links are now required on Android for any PayPal flow, not just app switch. I think for the v5 dev docs we should have a separate page for app link setup that we can refer to from any of the pages (PayPal web or app switch)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah didn't think about that! That's a good call to move it into it's own page when we do the v5 docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also like the idea of having this live in the Docs vs the repo when we start Android V5 docs!

APP_LINK_SETUP.md Outdated Show resolved Hide resolved
APP_LINK_SETUP.md Outdated Show resolved Hide resolved
@sarahkoop sarahkoop merged commit 40fffa0 into main Oct 1, 2024
3 checks passed
@sarahkoop sarahkoop deleted the app-link-setup-docs branch October 1, 2024 16:10
tdchow added a commit that referenced this pull request Oct 11, 2024
* main: (54 commits)
  Firebase App Distribution Branch (#1182)
  Fix lint warnings - replace kapt with ksp, remove unused properties and resources, added Intent extension functions for handling deprecated functions (#1181)
  [open dev] Cleanup integration tests (#1180)
  Update README and CHANGELOG (#1176)
  App link setup docs (#1171)
  Revert to Braintree Merchant Server (#1173)
  Prepare for development
  Release 5.0.0
  Remove BA toast from PatPal Fragment (#1172)
  [App Switch] Update CHANGELOG (#1166)
  Make pending request constructors public (#1169)
  [App Switch] Add analytic events (#1111)
  Fix 3DS Cancel (#1161)
  Fix `os_version` and `enablePayPalAppSwitch` (#1162)
  Fix analytic event timestamps (#1160)
  Rename handleReturnToAppFromBrowser to handleReturnToApp (#1158)
  Parse error messages from multiple possible fields in the error response (#1156)
  External Interface Access Control (#1155)
  Update Google Pay Integration (#1153)
  Batch Analytics Events by Session ID (#1152)
  ...

# Conflicts:
#	CHANGELOG.md
#	Demo/src/main/java/com/braintreepayments/demo/PayPalFragment.java
#	Demo/src/main/java/com/braintreepayments/demo/PayPalRequestFactory.java
#	Demo/src/main/res/layout/fragment_paypal.xml
#	PayPal/src/main/java/com/braintreepayments/api/paypal/PayPalRequest.kt
#	PayPal/src/main/java/com/braintreepayments/api/paypal/PayPalVaultRequest.kt
#	PayPal/src/test/java/com/braintreepayments/api/paypal/PayPalVaultRequestUnitTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants