Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytic event timestamps #1160

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix analytic event timestamps #1160

merged 2 commits into from
Sep 19, 2024

Conversation

tdchow
Copy link
Collaborator

@tdchow tdchow commented Sep 18, 2024

Summary of changes

  • There was an issue where the timestamps sent with analytic events were not accurate due to the timestamp being generated inside of a callback. This change generates the timestamp right when sendAnalyticsEvent() is called.

Checklist

  • Added a changelog entry
  • Relevant test coverage

Authors

List GitHub usernames for everyone who contributed to this pull request.

@tdchow tdchow requested a review from a team as a code owner September 18, 2024 19:46
@tdchow tdchow merged commit 4f70845 into main Sep 19, 2024
3 checks passed
@tdchow tdchow deleted the fix-analytics-timestamp branch September 19, 2024 14:54
tdchow added a commit that referenced this pull request Oct 11, 2024
@tdchow
Merge branch 'main' into user-phone-number
3712f50 
* main: (54 commits)
  Firebase App Distribution Branch (#1182)
  Fix lint warnings - replace kapt with ksp, remove unused properties and resources, added Intent extension functions for handling deprecated functions (#1181)
  [open dev] Cleanup integration tests (#1180)
  Update README and CHANGELOG (#1176)
  App link setup docs (#1171)
  Revert to Braintree Merchant Server (#1173)
  Prepare for development
  Release 5.0.0
  Remove BA toast from PatPal Fragment (#1172)
  [App Switch] Update CHANGELOG (#1166)
  Make pending request constructors public (#1169)
  [App Switch] Add analytic events (#1111)
  Fix 3DS Cancel (#1161)
  Fix `os_version` and `enablePayPalAppSwitch` (#1162)
  Fix analytic event timestamps (#1160)
  Rename handleReturnToAppFromBrowser to handleReturnToApp (#1158)
  Parse error messages from multiple possible fields in the error response (#1156)
  External Interface Access Control (#1155)
  Update Google Pay Integration (#1153)
  Batch Analytics Events by Session ID (#1152)
  ...

# Conflicts:
#	CHANGELOG.md
#	Demo/src/main/java/com/braintreepayments/demo/PayPalFragment.java
#	Demo/src/main/java/com/braintreepayments/demo/PayPalRequestFactory.java
#	Demo/src/main/res/layout/fragment_paypal.xml
#	PayPal/src/main/java/com/braintreepayments/api/paypal/PayPalRequest.kt
#	PayPal/src/main/java/com/braintreepayments/api/paypal/PayPalVaultRequest.kt
#	PayPal/src/test/java/com/braintreepayments/api/paypal/PayPalVaultRequestUnitTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saperi22 saperi22 saperi22 approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdchow @jaxdesmarais @saperi22