Skip to content

Improve input element selection logic #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fglueck wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve input element selection logic #52

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64451ea
Improve input element selection logic
fglueck Nov 21, 2025
1e28d55
Refactor input selection logic for checkEl
fglueck Nov 25, 2025
2a4b5d0
Update input initialization logic in form-data-json
fglueck Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/form-data-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,12 +748,21 @@ export default class FormDataJson {
isValidInput: ((input: HTMLInputElement | HTMLSelectElement | HTMLTextAreaElement | HTMLElement) => boolean | undefined) | null = null,
options: FormDataJsonOptionsToJson | FormDataJsonOptionsFromJson | FormDataJsonOptionsReset | FormDataJsonOptionsClear
): any {
const el = FormDataJson.getElement(checkEl)
if (!el) {
return []
let inputs = [];
if (Array.isArray(checkEl)) {
inputs = checkEl;
}
else if (checkEl.jquery && checkEl.length>1) {
const el = null;
inputs = checkEl.toArray();
}
else {
const el = FormDataJson.getElement(checkEl);
if (!el) {
return [];
}
inputs = Array.from(el.querySelectorAll('select, textarea, input, button'));
}

let inputs = Array.from(el.querySelectorAll('select, textarea, input, button'))
// if we have a form with a name, we need to find all attributes that have a "form" attribute with that name as value as well
if (options.includeLinkedFormElements && el instanceof HTMLFormElement && el.getAttribute('id')) {
const formId = el.getAttribute('id')
Expand Down Expand Up @@ -902,4 +911,4 @@ export default class FormDataJson {
}
return c
}
}
}