Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handover logger to RenderVersionFile #31

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Handover logger to RenderVersionFile #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .snippets/30.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
## Handover logger to RenderVersionFile
<!--
type: bugfix
scope: all
affected: all
-->

Handover logger of `update_version` to `RenderVersionFile` to avoid the creation and usage of the `RenderVersionFile` logger which does not respect the logging level settings of `update_version`
2 changes: 1 addition & 1 deletion src/changelog2version/update_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def main():
semver_string = version_extractor.parse_semver_line(
release_version_line=version_line)

file_renderer = RenderVersionFile()
file_renderer = RenderVersionFile(logger=logger)
semver_data = version_extractor.semver_data
additional_data = ""
if additional_version_info:
Expand Down
Loading