Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impro: bump nlohmann to 3.11.2 #982

Closed
wants to merge 2 commits into from
Closed

impro: bump nlohmann to 3.11.2 #982

wants to merge 2 commits into from

Conversation

sndth
Copy link

@sndth sndth commented Oct 31, 2023

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit fa2bdde
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65423bc7e8388e0008e3647f
😎 Deploy Preview https://deploy-preview-982--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ braindigitalis
❌ sndth
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the code Improvements or additions to code. label Oct 31, 2023
@braindigitalis
Copy link
Contributor

hi,
you need to sign the developer covenant via clabot, and also tick the checkboxes to confirm all was tested before this can be merged.
thanks!

@Jaskowicz1 Jaskowicz1 mentioned this pull request Nov 2, 2023
5 tasks
@Jaskowicz1
Copy link
Contributor

Since we've heard nothing back, we're closing this and reopening it in #991. We'll give this some testing outside our CIs to ensure that this working without any issues and so we can resolve any issues if required.

@Jaskowicz1 Jaskowicz1 closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants