Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed version_checker for UE. #970

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Jaskowicz1
Copy link
Contributor

This PR wraps the version checker in an if statement, checking if any UE definitions are declared. This means Unreal Engine will no longer constantly break with the version checker.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Oct 24, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 15ab3d1
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6537c8b914194e000840d068
😎 Deploy Preview https://deploy-preview-970--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis merged commit a6cd935 into brainboxdotcc:dev Oct 24, 2023
35 checks passed
@Jaskowicz1 Jaskowicz1 deleted the verchecker-changes branch November 13, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants