Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: refactor json.h out of include from discordevents.h #926

Merged
merged 3 commits into from
Oct 6, 2023
Merged

build: refactor json.h out of include from discordevents.h #926

merged 3 commits into from
Oct 6, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Oct 6, 2023

Surely this will save more than a couple seconds of build

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Oct 6, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 6, 2023
@Mishura4 Mishura4 reopened this Oct 6, 2023
@Mishura4 Mishura4 changed the base branch from master to dev October 6, 2023 22:46
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit fc248c2
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65208ea55d4ee60008eb51cf
😎 Deploy Preview https://deploy-preview-926--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jaskowicz1 Jaskowicz1 added the build Issue or Pull Request related to the build process label Oct 6, 2023
@braindigitalis braindigitalis merged commit f768e93 into brainboxdotcc:dev Oct 6, 2023
6 of 27 checks passed
Mishura4 added a commit that referenced this pull request Oct 6, 2023
@Mishura4
build: fix #926, speedrun to #1000 (#927)
91906ac
@Mishura4 Mishura4 deleted the json branch October 9, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees
No one assigned
Labels
build Issue or Pull Request related to the build process code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mishura4 @braindigitalis @Jaskowicz1