Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the error checks from sslclient.cpp to wsclient.cpp where they belong, so they dont cause excessive data copies or false alarms #902

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

braindigitalis
Copy link
Contributor

@braindigitalis braindigitalis commented Sep 30, 2023

The code added in a previous PR would cause unceccessary checks of the data every time we did SSL_read, this really belongs in wsclient when looking for the 101 reply, so i moved it.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

…elong, so they dont cause excessive data copies or false alarms
@github-actions
Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Sep 30, 2023
@braindigitalis braindigitalis changed the base branch from master to dev September 30, 2023 16:52
@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 17c17da
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65185288dd2c110008b23dcf
😎 Deploy Preview https://deploy-preview-902--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@braindigitalis braindigitalis merged commit cca47cf into dev Sep 30, 2023
50 checks passed
@braindigitalis braindigitalis deleted the optimise_ws_error_check branch September 30, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants