Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, chore, perf, style, feat, improv, refactor, test, docs: update dispatcher.h/.cpp #899

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Mishura4
Copy link
Member

@Mishura4 Mishura4 commented Sep 28, 2023

This PR allows events to be move and copy assigned.

That's it. Definitely nothing else in 800 line changes.

Just kidding :

  • Fixes style issues in dispatcher.h and dispatcher.cpp
  • Adds unit tests checking that the types can be copy constructed and assigned as well as move constructed and assigned
  • Changes the thread_local stop_event for event cancellation into a mutable bool inside of event_dispatch_t (yes, it still works)
  • Adds various small optimizations in dispatcher.cpp
  • Fixes some weird things (e.g. message_create_t::send taking with a non-const lvalue reference to dpp::message
  • Makes VS2022 use PCH because why not

API remains the same for everything

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@github-actions
Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Sep 28, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation build Issue or Pull Request related to the build process labels Sep 28, 2023
@Mishura4 Mishura4 reopened this Sep 28, 2023
@Mishura4 Mishura4 changed the base branch from master to dev September 28, 2023 19:36
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit b2f0e58
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/6515f1cd05ffff0008bc78c6
😎 Deploy Preview https://deploy-preview-899--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squeaky clean new code, when can we merge it 😄

@Jaskowicz1
Copy link
Contributor

squeaky clean new code, when can we merge it 😄

now plz, with a release too if possible <3

@Mishura4
Copy link
Member Author

When I fix ARM 😭
And tests apparently?

@braindigitalis
Copy link
Contributor

your new unit test fails

@Mishura4 Mishura4 marked this pull request as ready for review September 28, 2023 22:17
@Mishura4 Mishura4 removed the documentation Improvements or additions to documentation label Sep 28, 2023
@braindigitalis braindigitalis merged commit 1da01bf into brainboxdotcc:dev Sep 29, 2023
29 checks passed
@Mishura4 Mishura4 deleted the operators branch October 2, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants