Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: destroy spawn of satan type punning in ETF parser #894

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

braindigitalis
Copy link
Contributor

This removes two instances of type punning in the ETF parser. Please take note of the comments added to the function etf_parser::process_atom(). This is a performance hotspot and any changes to this function should be carefully profiled.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@braindigitalis braindigitalis changed the base branch from master to dev September 26, 2023 22:57
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 26, 2023
Copy link
Member

@Mishura4 Mishura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

src/dpp/etf.cpp Show resolved Hide resolved
@braindigitalis braindigitalis marked this pull request as ready for review September 26, 2023 23:44
@braindigitalis braindigitalis merged commit 5a9bcf5 into dev Sep 26, 2023
46 of 47 checks passed
@braindigitalis braindigitalis deleted the remove_etf_type_punner branch September 26, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants