fix: two segmentation faults in cluster::guild_edit_member and cluster::tick_timers/cluster::shutdown #1326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster::guild_edit_member
accesses invalid memory in its callback if the guild_member object is deallocated before thepost_rest
makes a call to the callback. Capturing the object as copy fixes this issue.cluster::shutdown
does not clear thenext_timer
map which causes segfaults incluster::tick_timers
if the timers are not removed before shutdown. Clearing the map after all timers are deleted resolves this.Code change checklist