Add type checking and fix issues

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 dist
-coverage
+coverage
+*.tsbuildinfo

package.json

@@ -8,11 +8,14 @@
   "main": "dist/index.js",
   "module": "dist/index.es.js",
   "scripts": {
-    "all": "run-s lint test build",
+    "all": "run-s lint check-types test build",
     "test": "karma start",
     "build": "rollup -c --bundleConfigAsCjs",
     "build:watch": "npm run build -- -w",
     "lint": "eslint .",
+    "check-types": "run-s check-types:*",
+    "check-types:src": "tsc",
+    "check-types:test": "tsc -p test",
     "start": "cross-env SINGLE_START=true npm run dev",
     "start:camunda": "cross-env SINGLE_START=camunda npm run dev",
     "dev": "npm test -- --auto-watch --no-single-run",
@@ -46,6 +49,7 @@
   "license": "MIT",
   "dependencies": {
     "@bpmn-io/feel-lint": "^2.1.0",
+    "@bpmn-io/lang-feel": "^2.4.0",
     "@camunda/feel-builtins": "^0.2.0",
     "@codemirror/autocomplete": "^6.16.2",
     "@codemirror/commands": "^6.8.0",
@@ -54,7 +58,6 @@
     "@codemirror/state": "^6.5.1",
     "@codemirror/view": "^6.36.2",
     "@lezer/highlight": "^1.2.1",
-    "@bpmn-io/lang-feel": "^2.4.0",
     "min-dom": "^4.2.1"
   },
   "devDependencies": {
@@ -63,6 +66,10 @@
     "@rollup/plugin-json": "^6.1.0",
     "@testing-library/dom": "^10.4.0",
     "@testing-library/user-event": "^14.6.1",
+    "@types/chai": "^5.2.3",
+    "@types/mocha": "^10.0.10",
+    "@types/sinon": "^17.0.4",
+    "@types/sinon-chai": "^4.0.0",
     "babel-loader": "^9.2.1",
     "babel-plugin-istanbul": "^7.0.0",
     "chai": "^4.5.0",
@@ -85,6 +92,7 @@
     "rollup": "^4.31.0",
     "sinon": "^17.0.1",
     "sinon-chai": "^3.7.0",
+    "typescript": "^5.9.3",
     "webpack": "^5.97.1"
   }
 }

src/autocompletion/index.js

@@ -1,4 +1,5 @@
 import { snippets, keywordCompletions } from '@bpmn-io/lang-feel';
+import { completeFromList } from '@codemirror/autocomplete';
 
 import { pathExpressionCompletion } from './pathExpression';
 import { variableCompletion } from './variable';
@@ -21,7 +22,7 @@ export function completions({ variables = [], builtins = [] }) {
   return [
     pathExpressionCompletion({ variables }),
     variableCompletion({ variables, builtins }),
-    snippets,
+    completeFromList(snippets),
     ...keywordCompletions
   ];
 }

src/autocompletion/pathExpression.js

@@ -20,7 +20,7 @@ export function pathExpressionCompletion({ variables }) {
     const nodeBefore = syntaxTree(context.state).resolve(context.pos, -1);
 
     if (!isPathExpression(nodeBefore)) {
-      return;
+      return null;
     }
 
     const expression = findPathExpression(nodeBefore);
@@ -41,26 +41,27 @@ export function pathExpressionCompletion({ variables }) {
       // only suggest if variable type matches
       if (
         childVar.isList !== 'optional' &&
-        !!childVar.isList !== path[i].isList
+         !!childVar.isList !== path[i].isList
       ) {
-        return;
+        return null;
       }
 
       options = childVar.entries;
     }
 
-    if (!options) return;
+    if (!options) return null;
 
-    options = options.map(v => ({
-      label: v.name,
-      type: 'variable',
-      info: v.info,
-      detail: v.detail
-    }));
+    const completionOptions = options.map(option => (
+      {
+        label: option.name,
+        type: 'variable',
+        info: option.info,
+        detail: option.detail
+      }));
 
     const result = {
       from: from,
-      options: options
+      options: completionOptions
     };
 
     return result;

src/autocompletion/variable.js

@@ -67,8 +67,8 @@ function getVariableSuggestions(variables, builtins) {
 
 /**
  * @param {import('..').Variable} variable
- * @param {number} boost
-
+ * @param {number} [boost]
+ *
  * @returns {import('@codemirror/autocomplete').Completion}
  */
 function createVariableSuggestion(variable, boost) {

src/core/index.js

@@ -13,12 +13,12 @@ import {
 /**
  * @typedef {object} Variable
  * @property {string} name name or key of the variable
- * @property {string} [info] short information about the variable, e.g. type
+ * @property {string | (() => HTMLElement)} [info] short information about the variable, e.g. type
  * @property {string} [detail] longer description of the variable content
- * @property {boolean} [isList] whether the variable is a list
- * @property {Array<Variable>} [schema] array of child variables if the variable is a context or list
+ * @property {boolean|'optional'} [isList] whether the variable is a list
+ * @property {Array<Variable>} [entries] array of child variables if the variable is a context or list
  * @property {'function'|'variable'} [type] type of the variable
- * @property {Array<{name: string, type: string}>} [params] function parameters
+ * @property {Array<{name: string, type?: string}>} [params] function parameters
  */
 
 /**

src/globals.d.ts

@@ -0,0 +1,10 @@
+// Global type definitions for FEEL Editor
+
+import { Extension as CodeMirrorExtension } from "@codemirror/state";
+
+declare global {
+  type DOMNode = HTMLElement;
+  type Extension = CodeMirrorExtension;
+}
+
+export {};