Skip to content

Commit

Permalink
chore: make properties panel a keyboard trap
Browse files Browse the repository at this point in the history
This ensure properties panel focus is not lost when I mouse down on,
i.e. a label. On the other hand this remains unfocusable through
keyboard navigation. We can consider to change that some day, just
not today 😉.
  • Loading branch information
nikku committed Nov 20, 2024
1 parent 3e8bb3b commit 22764d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/render/BpmnPropertiesPanelRenderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export default class BpmnPropertiesPanelRenderer {
this._getFeelPopupLinks = getFeelPopupLinks;

this._container = domify(
'<div style="height: 100%" class="bio-properties-panel-container"></div>'
'<div style="height: 100%" tabindex="-1" class="bio-properties-panel-container"></div>'
);

domEvent.bind(this._container, 'focusin', (event) => this._checkFocus(event));
Expand Down

0 comments on commit 22764d0

Please sign in to comment.