Skip to content

Conversation

@paydaycay
Copy link

CPU types are missing when creating virtual_environment_vm resource.

Proxmox UI is able to create EPYC-Rome-v3 and EPYC-Rome-v4 CPUs but the provider cannot.

Contributor's Note

  • I have run make lint and fixed any issues.
  • I have updated documentation (FWK: schema descriptions + make docs; SDK: manual /docs/ edits).
  • I have added / updated acceptance tests for any new or updated resources / data sources.
  • I have run make example to verify the change works (mainly for SDK / provider config changes).

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2495

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @paydaycay, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Proxmox Terraform provider by introducing support for EPYC-Rome-v3 and EPYC-Rome-v4 CPU types for virtual machines. This resolves an incompatibility where these CPU types could be used in the Proxmox UI but not through the Terraform provider, thereby expanding the configuration options available to users and improving feature parity.

Highlights

  • CPU Type Support: Added support for EPYC-Rome-v3 and EPYC-Rome-v4 CPU types, enabling their use when creating virtual_environment_vm resources via the Terraform Proxmox provider.
  • Documentation Update: Updated the documentation for the virtual_environment_vm resource to reflect the newly supported EPYC-Rome-v3 and EPYC-Rome-v4 CPU types.
  • Schema and Validation Enhancement: Integrated the new CPU types into the resource schema and validation logic, ensuring proper configuration and error handling within the provider.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for EPYC-Rome-v3 and EPYC-Rome-v4 CPU types in the virtual_environment_vm resource, updating the schema, validators, and documentation. The code changes are correct, but there's a minor duplication issue in the documentation that should be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vm: unable to create vm with EPYC-Rome-v3 or EPYC-Rome-v4 cpu type

1 participant