Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History fix #954

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

History fix #954

wants to merge 3 commits into from

Conversation

roastedGhosty
Copy link

@roastedGhosty roastedGhosty commented Nov 12, 2024

Resolves #819.
Sets a parameter on gallery navigation to replace the history state on every navigation change. Thus when navigating photos in the lightbox each photo view acts as the most recent navigation state and when hitting back, it returns to the album.

@bpatrik
Copy link
Owner

bpatrik commented Jan 5, 2025

That is an intended behavior so you can copy the url and it will show the exact same photo that you have open.

@roastedGhosty
Copy link
Author

Hi can you clarify what you are responding to? Nothing about this code change undoes the behavior you are referring to. As posted in the issue thread here is a gif of how this code change looks (the gif takes a few seconds to load):
firefox_1jlK57aij7
The URL changes with each image open and when hitting browser back we see that the lightbox is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser back functionality
2 participants