Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makeselectable): disable arrow navigation when in overlay #3866

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

ahorowitz123
Copy link
Contributor

@ahorowitz123 ahorowitz123 commented Jan 24, 2025

Prevent arrow navigation into tables when either a flyout or dropdown menu is rendered in the DOM
This prevents arrow navigation when the following elements are open on the all files page:

  • Task flyout
  • Notifications flyout
  • Recents carousel item overflow menu
  • list/grid item overflow menu
  • new button menu

@ahorowitz123 ahorowitz123 requested a review from a team as a code owner January 24, 2025 17:01
Copy link
Contributor

@JChan106 JChan106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit 512c975 into box:master Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants