Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): Simplify codeowners to support mergify restrictions #1948

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

jstoffan
Copy link
Contributor

@jstoffan jstoffan commented Feb 19, 2020

It looks like Mergify doesn't fully support CODEOWNERS without review-requested=0 due to an open issue, which would be needed to support multiple owners. We'll want to keep owners as simple as possible for now.

@jstoffan jstoffan requested review from a team as code owners February 19, 2020 08:12
@boxcla
Copy link

boxcla commented Feb 19, 2020

Verified that @jstoffan has signed the CLA. Thanks for the pull request!

@jstoffan jstoffan force-pushed the codeowners-fix branch 3 times, most recently from b2fd118 to e791536 Compare February 19, 2020 08:20
@jstoffan jstoffan changed the title chore(codeowners): Fix mergify condition and simplify codeowners chore(codeowners): Simplify codeowners to support mergify restrictions Feb 19, 2020
@jstoffan jstoffan force-pushed the codeowners-fix branch 3 times, most recently from ad6d334 to 20bd64b Compare February 19, 2020 08:35
@jstoffan jstoffan force-pushed the codeowners-fix branch 3 times, most recently from c8172e1 to bd995cd Compare February 19, 2020 08:49
alexkrolick
alexkrolick previously approved these changes Feb 19, 2020
@jstoffan jstoffan merged commit 14ed504 into box:master Feb 19, 2020
@jstoffan jstoffan deleted the codeowners-fix branch February 19, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants