Create RequestsSessionNetwork #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is the same as the former `DefaultNetwork` class, except that it accepts an optional `session` constructor parameter, for clients to specify a session of their choosing rather than having it constructed automatically. `DefaultNetwork` is aliased to `RequestsSessionNetwork`, for backwards-compatibility. This enables the boxsdk's testing framework to start using the `betamax` to record real network calls and responses. Although we currently only add one such test, this is a potential alternative to mock-box functional tests in the future. This also allows for dependents of boxsdk to write `betamax` tests as well.
|
Verified that @jmoldow has signed the CLA. Thanks for the pull request! |
Move the betamax fixtures to an installable pytest plugin, so that dependent applications can also make use of them.
jmoldow
force-pushed
the
requests_session
branch
from
2c8ed6b
to
d90dd57
Compare
Jeff-Meadows
approved these changes
Oct 2, 2017
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is the same as the former
DefaultNetworkclass,except that it accepts an optional
sessionconstructorparameter, for clients to specify a session of their choosing
rather than having it constructed automatically.
DefaultNetworkis aliased toRequestsSessionNetwork, forbackwards-compatibility.
This enables the boxsdk's testing framework to start using the
betamaxto record real network calls and responses. Althoughwe currently only add one such test, this is a potential
alternative to mock-box functional tests in the future.
This also allows for dependents of boxsdk to write
betamaxtests as well.