Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility for setting up coordinates for a tokamak system #3046

Open
wants to merge 96 commits into
base: refactor-coordinates
Choose a base branch
from

Conversation

tomc271
Copy link
Collaborator

@tomc271 tomc271 commented Dec 16, 2024

Extracted duplicated code for creating a Coordinates object for a tokamak system to a new file.

elm-pb
laplacexy/laplace_perp
gyro-gem example (using zero for I parameter)
alfven-wave example (using sinty for I parameter)
(rather than passing one to it for it to modify).
as `DataFileFacade.addOnce` method does not take const arguments.
because the function is marked const.
but need to copy value to a non-const variable to pass to `DataFileFacade.addOnce` method.
@tomc271 tomc271 force-pushed the dry-up-examples branch 2 times, most recently from 6a3c85a to d08ecf9 Compare January 28, 2025 13:51
@tomc271 tomc271 changed the title Dry up examples Utility for setting up coordinates for a tokamak system Jan 29, 2025
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can probably be further polished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants