-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utility for setting up coordinates for a tokamak system #3046
Open
tomc271
wants to merge
96
commits into
refactor-coordinates
Choose a base branch
from
dry-up-examples
base: refactor-coordinates
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,374
−5,877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…txy) to new file examples/common.hxx
elm-pb laplacexy/laplace_perp gyro-gem example (using zero for I parameter) alfven-wave example (using sinty for I parameter)
(rather than passing one to it for it to modify).
…esFactory constructor.
as `DataFileFacade.addOnce` method does not take const arguments.
because the function is marked const.
but need to copy value to a non-const variable to pass to `DataFileFacade.addOnce` method.
…okamak_coordinates() method
class `TokamakCoordinatesFactory` renamed to `TokamakCoordinates` method `tokamak_coordinates_factory` renamed to `tokamak_coordinates`
and its methods free functions.
…n't return anything
since TokamakCoordinates function now doesn't return Coordinates.
6a3c85a
to
d08ecf9
Compare
ZedThree
reviewed
Jan 29, 2025
ZedThree
reviewed
Jan 29, 2025
dschwoerer
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can probably be further polished.
d08ecf9
to
0537766
Compare
ZedThree
reviewed
Feb 19, 2025
ZedThree
requested changes
Feb 19, 2025
0537766
to
e4a6b8d
Compare
ZedThree
reviewed
Feb 21, 2025
(Rename 'ShearFactor' back to 'I')
…ptional) integer parameter rather than a boolean Suggested on PR.
…oordinates()->dx()
e4a6b8d
to
6b4ddcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted duplicated code for creating a Coordinates object for a tokamak system to a new file.