Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing combo letter when removing a drive #3616

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

EmoonX
Copy link
Contributor

@EmoonX EmoonX commented Dec 19, 2024

Description

A replacement to #3610 ("digging gold and finding diamonds" moment).

Fix an issue where removing a drive wouldn't have its letter appearing in the combo list (which means you'd need to do the whole process of restarting Bottles to be able to add it again).

Also refactored and simplified some stuff; e.g. __alphabet isn't a volatile list anymore for eager lookup, but just a fixed "ABCDEFGHIJKLMNOPQRSTUVWXYZ" string.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just try adding/removing a bunch of drives. Combo letters (unused ones) and drive letters (used ones) should form a partition of the alphabet (A to Z), i.e. each and every letter should belong to one and only one of the groups at any time.

Copy link
Member

@mirkobrombin mirkobrombin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jntesteves jntesteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirkobrombin mirkobrombin enabled auto-merge (rebase) December 20, 2024 08:48
@mirkobrombin mirkobrombin merged commit 63237f7 into bottlesdevs:main Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants