Fix missing combo letter when removing a drive #3616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A replacement to #3610 ("digging gold and finding diamonds" moment).
Fix an issue where removing a drive wouldn't have its letter appearing in the combo list (which means you'd need to do the whole process of restarting Bottles to be able to add it again).
Also refactored and simplified some stuff; e.g.
__alphabet
isn't a volatile list anymore for eager lookup, but just a fixed"ABCDEFGHIJKLMNOPQRSTUVWXYZ"
string.Type of change
How Has This Been Tested?
Just try adding/removing a bunch of drives. Combo letters (unused ones) and drive letters (used ones) should form a partition of the alphabet (
A
toZ
), i.e. each and every letter should belong to one and only one of the groups at any time.