Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toc.py): Use UTF-8 encoding for reading files #148

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(toc.py): Use UTF-8 encoding for reading files #148

merged 1 commit into from
Jul 16, 2024

Conversation

Rubyfi
Copy link
Contributor

@Rubyfi Rubyfi commented Jul 16, 2024

Fixes #147

@Rubyfi Rubyfi requested a review from twodrops as a code owner July 16, 2024 14:16
twodrops
twodrops approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@twodrops twodrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rubyfi for the quick fix.
I hope the DCO check can be fixed easily.

@Rubyfi
Copy link
Contributor Author

Rubyfi commented Jul 16, 2024 •
edited
Loading

Thanks @Rubyfi for the quick fix. I hope the DCO check can be fixed easily.

For some reason, the web UI does not automatically sign-off commits.
I signed it off locally and it seems to work now.

@twodrops twodrops merged commit d959f75 into boschglobal:main Jul 16, 2024
2 checks passed
@choeppler
Copy link
Member

For some reason, the web UI does not automatically sign-off commits. I signed it off locally and it seems to work now.

I updated the org settings, so sign-off of commits via web UI should work now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twodrops twodrops twodrops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doxysphinx crashed due to UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d
3 participants
@Rubyfi @choeppler @twodrops