Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clap crate for CLI #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

enrichman
Copy link

@enrichman enrichman commented May 13, 2024

// TODO use a proper parsing lib

As per comment found in main this PR adds the clap crate to parse the arguments and create a more standard CLI.

Screen Shot 2024-05-13 at 18 18 26

The behaviour is the same as before, but in the future I would personally change/move the test command into some internal thing, instead of having it in the "main" binary.

It will be nice to have a borgo build, and eventually a borgo test that will execute some Borgo "test", moving the "compiler" test to something else. 😄
Since the project is named compiler that is the default name. borgo would be better.

@jmackie
Copy link

jmackie commented May 15, 2024

Since the project is named compiler that is the default name. borgo would be better.

My man, try smashing this into the Cargo.toml:

[[bin]]
name = "borgo"
path = "src/main.rs"

@enrichman
Copy link
Author

Since the project is named compiler that is the default name. borgo would be better.

My man, try smashing this into the Cargo.toml:

[[bin]]
name = "borgo"
path = "src/main.rs"

Yep, I know, but thanks for pointing this out. I just didn't want to make this "breaking" change.

What's your thought about this @alpacaaa? Can we do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants