msys2: disable SETUPTOOLS_USE_DISTUTILS=stdlib hack #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The msys2 changelog says it is only needed for setuptools < 70.2.0: https://www.msys2.org/docs/python/#known-issues https://setuptools.pypa.io/en/stable/history.html#v70-2-0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8395 +/- ##
=======================================
Coverage 81.57% 81.58%
=======================================
Files 70 70
Lines 12700 12700
Branches 2298 2298
=======================================
+ Hits 10360 10361 +1
Misses 1688 1688
+ Partials 652 651 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The msys2 changelog says it is only needed for setuptools < 70.2.0:
https://www.msys2.org/docs/python/#known-issues
https://setuptools.pypa.io/en/stable/history.html#v70-2-0
See also TODO in #8381.