fixes for non-unique archive names #8393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8393 +/- ##
==========================================
- Coverage 81.69% 81.57% -0.12%
==========================================
Files 70 70
Lines 12699 12700 +1
Branches 2300 2298 -2
==========================================
- Hits 10374 10360 -14
- Misses 1671 1688 +17
+ Partials 654 652 -2 ☔ View full report in Codecov by Sentry. |
ThomasWaldmann
changed the title
For Archive(), always use the archive id, not the archive name! Also: sorting by timestamp, improved output.
For Archive(), always use the archive id, not the archive name! Also: remove with_archive decorator usage to get more consistent code.
For Archive(), always use the archive id, not the archive name!
For Archive(), always use the archive id, not the archive name!
For Archive(), always use the archive id, not the archive name!
For Archive(), always use the archive id, not the archive name!
ThomasWaldmann
force-pushed
the
fix-compact-nonunique-names
branch
from
bd0f91b
to
03b139e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Archive(), always use the archive id, not the archive name!