Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation (installation, env variable, faq, support) #29

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Improve documentation (installation, env variable, faq, support) #29

merged 1 commit into from
Jul 29, 2019

Conversation

AltNico
Copy link
Contributor

@AltNico AltNico commented Jul 11, 2019

Partly as a result of #14.

@AltNico AltNico changed the title Improve documentation (installation, env variable, faq) Improve documentation (installation, env variable, faq, support) Jul 11, 2019
Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the docs update, some notes/remarks.

docs/usage.rst Outdated
@@ -12,6 +12,12 @@ options. The following sections will describe each in detail.
General
-------

Note that |project_name| will ask you for your repo's passphrase
which blocks the import until you enter it. To let |project_name|
continue automatically, you can pass the environmental variable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment variable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, it is borg asking for the passphrase, right? not borg-import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment variable

Done, thanks!

also, it is borg asking for the passphrase, right? not borg-import.

This might be right technically, but to me as a user it seems like borg-import asked for it, since I executed a borg-import command and not a borg one.
However, I can change it from borg-import to borg if you want. I just think that it might confuse people not knowing the relationship between borg and borg-import.

@@ -4,7 +4,8 @@ What is borg-import?
borg-import can import backups from some other backup software, currently supported are:

- rsnapshot
- simple rsync+hardlinks (One folder per archive, using folder mtime)
- ``rsynchl``: simple rsync+hardlinks (One folder per archive, using folder mtime)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rather use rsync-hl or rsync+hardlinks as shortcut for this.

having the char sequence synch (-> synchronization) in there makes it difficult to see what it means for people who do not know already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added rsynchl because I wanted to directly give users the mode to call with borg-import. I agree that rsynchl should might get renamed to something like rsync-hl, but this is out of scope of this PR.

@ThomasWaldmann ThomasWaldmann merged commit e3e3284 into borgbackup:master Jul 29, 2019
@ThomasWaldmann
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants