Open
Conversation
All the implicit special member functions made explicit in this PR. It fixes the compilation and test runs with `./b2 libs/numeric/ublas/test/ cxxstd=17 "cxxflags=-Werror=deprecated-copy" toolset=clang-13 -j4`
Collaborator
|
If I'm correct, it won't be a problem if we follow the rule of six. This warning arises when you give the copy assignment constructor without providing the default copy constructor. I assume the ublas code base follows the rule of six. If it does not, we have to fix that. |
Member
Author
|
Yes, you are right. This PR adds the missing functions for C++11 |
Collaborator
Ok. |
amitsingh19975
approved these changes
Feb 7, 2022
Collaborator
amitsingh19975
left a comment
amitsingh19975
left a comment
There was a problem hiding this comment.
It looks good, and thanks for contributing.
Member
Author
|
Gentle reminder |
Member
Author
|
@bassoy gentle reminder |
Member
Author
|
@amitsingh19975 could you please somehow speedup the PR review process? |
Collaborator
|
It's up to others. I cannot do anything. I would recommend contacting @bassoy via email or someone who has much more power than me. |
Member
Author
|
@bassoy Please merge |
shikharvashistha
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the implicit special member functions made explicit in this PR.
It fixes the compilation and test runs with
./b2 libs/numeric/ublas/test/ cxxstd=17 "cxxflags=-Werror=deprecated-copy" toolset=clang-13 -j4