Incorrect parameter ordering in element_sub #146
Open
harjot20022001 wants to merge 1 commit intoboostorg:developfrom
Open
Incorrect parameter ordering in element_sub #146harjot20022001 wants to merge 1 commit intoboostorg:developfrom
harjot20022001 wants to merge 1 commit intoboostorg:developfrom
Conversation
harjot20022001
changed the title
Michel150
approved these changes
Jan 10, 2022
isaac868
approved these changes
Feb 13, 2022
isaac868
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call in the first element_sub overload is changed to:
element_wise(a, b, result, compute::minus(), queue);
as opposed to
element_wise(a, b, compute::minus(), result, queue);
Fixes #129