Defined a geometry for polyhedron #789

Siddharth-coder13 · 2020-12-28T10:39:58Z

As suggested by @barendgehrels and @vissarion in comments #683, I defined geometry for polyhedral surfaces.

barendgehrels

Looks like a good start!

But I can't see how it works yet. It looks quite unfinished.

Can you add

a unit test, specifically for the polyhedron itself
a unit test, for the wkt support (it seems as started too) of the polyhedron, to read it and to write it?

As far as I can judge the code, it won't work yet, so you will probably need to modify parts of the source code too.

include/boost/geometry/geometries/polyhedron.hpp

Siddharth-coder13 · 2020-12-29T05:52:53Z

As far as I can judge the code, it won't work yet, so you will probably need to modify parts of the source code too.

I checked the code, after using it in one of the examples and tried to make sure that it doesn't throw any error, but I think there is a need to implement wkt support for a polyhedron, to see its working.

include/boost/geometry/geometries/polyhedron.hpp

vissarion

@Siddharth-coder13 thanks for the efforts!

From the design of the code I understand that the concept of a polyhedron is not very clear to you. I recommend to read the OGC standard e.g. https://www.ogc.org/standards/sfa and construct some unit tests (as @barendgehrels suggested). This will give you more intuition.

I also recommend to change the name from Polyhedron to PolyhedralSurface as in the standard.

include/boost/geometry/geometries/polyhedron.hpp

vissarion · 2020-12-29T15:51:08Z

include/boost/geometry/geometries/polyhedron.hpp

+
+namespace model
+{
+


Please add doxygen comments here to describe the parameters of the geometry.

barendgehrels

It should be simpler, clearer and more concrete.

include/boost/geometry/core/tags.hpp

include/boost/geometry/geometries/PolyhedralSurface.hpp

include/boost/geometry/io/wkt/detail/prefix.hpp

Siddharth-coder13 · 2021-01-06T13:56:29Z

After spending a week on the codebase, it seems to me that wkt input and output depends on multiple header files, including dimensions check and concept check.

To read inputs, I added the following codes:-

read.hpp -

    template<typename PolyhedralSurface>
    struct polyhderal_surface_parser
    {
        typedef typename ring_return_type<PolyhedralSurface>::type ring_return_type;
        typedef container_appender<ring_return_type> appender;

        static inline void apply(tokenizer::iterator& it,
                                 tokenizer::iterator const& end,
                                 std::string const& wkt,
                                 ring_return_type& ring)
        {
            handle_open_parenthesis(it, end, wkt);
            int i = 0;
            while(it != end && *it != ")"){
                appender::apply(it, end, wkt, ring);
                i++;
            }
            handle_close_parenthesis(it, end, wkt);
     
       }
   };

ring_type.hpp -

    template <typename PolyhedralSurface>
    struct ring_return_type<polyhedral_surface_tag, PolyhedralSurface>
    {
        typedef PolyhedralSurface& type;
    };

   template <typename PolyhedralSurface>
   struct ring_type<polyhedral_surface_tag, PolyhedralSurface>
   {
       typedef typename std::remove_reference
           <
               typename ring_return_type<polyhedral_surface_tag, PolyhedralSurface>::type
           >::type type;
   };

PolyhedralSurface_concept.hpp-

    #ifndef BOOST_GEOMETRY_GEOMETRIES_CONCEPTS_POLYHEDRALSURFACE_HPP
    #define BOOST_GEOMETRY_GEOMETRIES_CONCEPTS_POLYHEDRALSURFACE_HPP

    #include <boost/concept_check.hpp>
    #include <boost/range/concepts.hpp>
    #include <boost/geometry/core/access.hpp>
    #include <boost/geometry/core/ring_type.hpp>
    #include <boost/geometry/geometries/concepts/ring_concept.hpp>

    namespace boost { namespace geometry { namespace concepts 
    {


    template <typename Geometry>
    class PolyhedralSurface
    {

    #ifndef DOXYGEN_NO_CONCEPT_MEMBERS

	    typedef typename ring_type<Geometry>::type ring_type;
	
	
   	    //BOOST_CONCEPT_ASSERT( (concepts::Ring<ring_type>) );

    public:
	
	    BOOST_CONCEPT_USAGE(PolyhedralSurface)
	    {

		    Geometry* polyhedralSurface = 0;
		    ring_type* ring = 0;

	    } 
    #endif
	
    };

    } // namepspace concepts

    } // namespace geometry

    } // namespace boost
    #endif

I don't know why I am getting this error every time I build

file included from ../../../boost/geometry/core/ring_type.hpp:27,
             from ../../../boost/geometry/core/closure.hpp:24,
             from ../../../boost/geometry/geometry.hpp:34,
             from 01_point_example.cpp:15:
../../../boost/geometry/core/coordinate_dimension.hpp: In instantiation of ‘struct 
boost::geometry::traits::dimension<boost::geometry::model::ring<boost::geometry::model::point<double, 3,   
boost::geometry::cs::cartesian>, true, true>, void>’:
../../../boost/geometry/core/coordinate_dimension.hpp:63:8:   required from ‘struct 
boost::geometry::core_dispatch::dimension<boost::geometry::point_tag, 
boost::geometry::model::ring<boost::geometry::model::point<double, 3, boost::geometry::cs::cartesian>, true, true> >’
../../../boost/geometry/core/coordinate_dimension.hpp:58:8:   required from ‘struct 
boost::geometry::core_dispatch::dimension<boost::geometry::polyhedral_surface_tag, 
boost::geometry::model::PolyhedralSurface<boost::geometry::model::ring<boost::geometry::model::point<double, 3, 
boost::geometry::cs::cartesian>, true, true> > >’
../../../boost/geometry/core/coordinate_dimension.hpp:88:8:   required from ‘struct
 boost::geometry::dimension<boost::geometry::model::PolyhedralSurface<boost::geometry::model::ring<boost::geometry::
model::point<double, 3, boost::geometry::cs::cartesian>, true, true> > >’
../../../boost/geometry/io/wkt/read.hpp:567:51:   required from ‘bool boost::geometry::detail::wkt::initialize(const tokenizer&, 
const string&, const string&, boost::tokenizer<boost::char_separator<char> >::iterator&, 
boost::tokenizer<boost::char_separator<char> >::iterator&) [with Geometry = 
boost::geometry::model::PolyhedralSurface<boost::geometry::model::ring<boost::geometry::model::point<double, 3, 
boost::geometry::cs::cartesian>, true, true> >; boost::geometry::detail::wkt::tokenizer = 
boost::tokenizer<boost::char_separator<char> >; std::string = std::__cxx11::basic_string<char>; 
boost::tokenizer<boost::char_separator<char> >::iterator = boost::token_iterator<boost::char_separator<char>, 
__gnu_cxx::__normal_iterator<const char*, std::__cxx11::basic_string<char> >, std::__cxx11::basic_string<char> >]’
../../../boost/geometry/io/wkt/read.hpp:596:33:   required from ‘static void 
boost::geometry::detail::wkt::geometry_parser<Geometry, Parser, PrefixPolicy>::apply(const string&, Geometry&) [with 
Geometry = boost::geometry::model::PolyhedralSurface<boost::geometry::model::ring<boost::geometry::model::point<double, 
3, boost::geometry::cs::cartesian>, true, true> >; Parser = boost::geometry::detail::wkt::polyhderal_surface_parser; 
PrefixPolicy = boost::geometry::detail::wkt::prefix_polyhedral_surface; std::string = std::__cxx11::basic_string<char>]’
../../../boost/geometry/io/wkt/read.hpp:942:70:   required from ‘void boost::geometry::read_wkt(const string&, Geometry&) [with 
Geometry = boost::geometry::model::PolyhedralSurface<boost::geometry::model::ring<boost::geometry::model::point<double, 
3, boost::geometry::cs::cartesian>, true, true> >; std::string = std::__cxx11::basic_string<char>]’
01_point_example.cpp:124:282:   required from here
../../../boost/geometry/core/static_assert.hpp:28:81: error: static assertion failed: Not implemented for this Point type.
   28 | static_assert(boost::geometry::detail::static_assert_check<false, __VA_ARGS__>::value, MESSAGE)
      |                                                                                 ^~~~~
../../../boost/geometry/core/coordinate_dimension.hpp:45:5: note: in expansion of macro 
‘BOOST_GEOMETRY_STATIC_ASSERT_FALSE’
   45 |     BOOST_GEOMETRY_STATIC_ASSERT_FALSE(
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I am also getting more error like the above, I need some help in understanding why this error turns up every time.

barendgehrels · 2021-01-07T17:13:12Z

The message indicates that the code expects a point, or an instance implementing the Point Concept, but it is not a point.

Glancing through your code, the problem is probably here.

appender::apply(it, end, wkt, ring);

and it wants to append a point to a ring - but you get a ring, because you've a collection of rings here. Is that possible? It's just a guess, I didn't compile your code.
You might comment that line and see if the error disappears (of course it won't work correctly then, but at least you know the line which needs some fixing).

Siddharth-coder13 · 2021-02-07T09:17:31Z

Hey, @barendgehrels will you please review this PR, as I have implemented wkt read feature for polyhedral surfaces and I will also implement wkt write feature in a new PR, once this one gets merged.

Siddharth-coder13 · 2021-02-09T05:42:13Z

@mloskot @vissarion @awulkiew

mloskot · 2021-02-11T22:42:35Z

@Siddharth-coder13 Somehow this PR #789 and PR #782 have become a mess and they both contain the same commits (e.g. Defined a geometry for polyhedron that is 0961662e6e45878eda378f85dd734ae1922f7110). I have to admit this makes it quite impossible to review. I don't know what happened.

Siddharth-coder13 · 2021-02-12T01:16:09Z

@Siddharth-coder13 Somehow this PR #789 and PR #782 have become a mess and they both contain the same commits (e.g. Defined a geometry for polyhedron that is 0961662e6e45878eda378f85dd734ae1922f7110). I have to admit this makes it quite impossible to review. I don't know what happened.

Actually, this PR is the most current version of my local repo, it contains all the changes I have done so far, since my last PR doesn't gets merged, so I have to make a new branch in order to contribute.
There are three main commits :-

Prefix wkt:z for 3d geometries.
Definition of polyhedral surfaces.
Wkt read implementation.

mloskot · 2021-02-12T07:48:16Z

It's unfortunate. The 1 needs to be in the other separate PR and 2+3 as a separate feature in this PR.

I understand this may make your Git operations less convenient but these two are distinct features, they should be treated independently.

Siddharth-coder13 · 2021-02-12T08:04:59Z

It's unfortunate. The 1 needs to be in the other separate PR and 2+3 as a separate feature in this PR.

I understand this may make your Git operations less convenient but these two are distinct features, they should be treated independently.

Yeah, I know both the things are different, using git sometimes is quite complex. I guess the only thing I can do now is to revert 1, and then this PR will become a separate PR for polyhedral surfaces.

You may review 2 and 3 if you have any changes to suggest, as I want this PR to get merged, for 1 I will submit another PR after discussion if Z is to add or not.

mloskot · 2021-02-12T08:33:42Z

I'd strongly suggest to not to close any existing PRs and to not to open any new PRs.

Prefix wkt:z for 3d geometries.

This should be in the PR #782

Definition of polyhedral surfaces.

Wkt read implementation.

These two should be in this PR #789

Since there should be no dependency between the two PRs, that is, the changes in #782 are not required by the #789, then I'd simply suggest to:

In each of your local branches from which you submitted these PRS remove all commits that do not belong.
- You can git rebase -i, or
- You can rename this broken 3d-geometries local branch to e.g. old/3d-geometries, create new branch named 3d-geometries based on develop, then git cherry-pickcorrect commits fromold/3d-geometriesto3d-geometries`
Finally, git push --force to update the PRs.

By the way, this situation should also give you why it is a bad idea to develop any contributions in your fork's develop branch (like you did in PR #782). Instead, always create a topic branch and submit PR from a topic branch. That way, you can easily 'replace' PR branches in your remote without affecting your local develop branch. Topic branches save time!

vissarion · 2021-02-12T09:29:18Z

@Siddharth-coder13 as an addition to the excellent comments from @mloskot you could also have a look at https://github.com/boostorg/geometry/wiki/Contribution-Tutorial

mloskot

A few nit-picks

example/01_point_example.cpp

include/boost/geometry/geometries/concepts/PolyhedralSurface_concept.hpp

include/boost/geometry/geometries/concepts/check.hpp

include/boost/geometry/geometries/concepts/PolyhedralSurface_concept.hpp

Siddharth-coder13 · 2021-02-27T11:03:49Z

Hey @mloskot, I think this PR is able to merge now.

Siddharth-coder13 · 2021-02-27T11:05:33Z

Hey @mloskot, I think this PR is able to merge now.

or suggest changes if any.

barendgehrels · 2021-02-27T13:55:06Z

Hey @mloskot, I think this PR is able to merge now.

or suggest changes if any.

It’s big, important and needs to be reviewed and approved properly, by multiple people.

mloskot · 2021-02-27T18:43:22Z

@Siddharth-coder13 Please, hit the "Resolve conversation" for the items that you have addressed. This way, we can see what's been done and what's not.

barendgehrels

Thanks for the update!

It's much better, but not ready yet. See my comments.

As asked earlier:

Can you add

a unit test, specifically for the polyhedron itself (without wkt)
a: create it from scratch
b: modify it
c: iterate through it
d: clear it
e: check the concepts
such that we can really see how it works internally?
a unit test, for the wkt support of the polyhedral surface, to read it and to write it?
documentation including an example for the user (doc/src/examples/geometries/polyhedral_surface.cpp)

And please check yourself for consistencies in capitilization of filenames and struct/class names, for the style (I know in the current code we've many places where C++11 is not yet applied - but now we can)

example/01_point_example.cpp

include/boost/geometry/algorithms/clear.hpp

include/boost/geometry/core/point_type.hpp

include/boost/geometry/io/wkt/read.hpp

include/boost/geometry/io/wkt/write.hpp

Siddharth-coder13 · 2021-03-05T04:19:10Z

Hey, @barendgehrels Thanks for your reviews, but I think this point needs a separate PR, because a single PR can not define everything about polyhedral surfaces.

documentation including an example for the user (doc/src/examples/geometries/polyhedral_surface.cpp)

I will do the rest changes asap.

barendgehrels · 2021-03-11T18:12:10Z

Hey, @barendgehrels Thanks for your reviews, but I think this point needs a separate PR, because a single PR can not define everything about polyhedral surfaces.

documentation including an example for the user (doc/src/examples/geometries/polyhedral_surface.cpp)

I will do the rest changes asap.

Thank you! Success!
I think a separate PR for documentation will be fine.

Siddharth-coder13 · 2021-04-12T05:26:42Z

Hello @mloskot @barendgehrels @vissarion @awulkiew, as I have extended this PR as a project in GSOC'21 including other features of polyhedral surfaces. I want to get this PR merged before the GSOC period starts. It would be of great help if you leave your comment on this.

barendgehrels · 2021-05-12T08:32:06Z

Hi @Siddharth-coder13 , sorry for the late reply. I think it looks good now!

There is no unit test yet, did you plan to do that in this PR or in a next one (along with the documentation)? Documentation we can do later but a unit test is normally included in a PR (especially for new stuff).

Siddharth-coder13 · 2021-05-12T19:21:28Z

Hi @barendgehrels , thanks for the review. Actually, I added the example file of polyhedral surfaces, if unit test is needed in this PR, then I will add it asap.

vissarion added the enhancement label Dec 28, 2020

barendgehrels requested changes Dec 28, 2020

View reviewed changes

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

barendgehrels reviewed Dec 28, 2020

View reviewed changes

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

barendgehrels reviewed Dec 28, 2020

View reviewed changes

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

vissarion reviewed Dec 29, 2020

View reviewed changes

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

vissarion requested changes Dec 29, 2020

View reviewed changes

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

include/boost/geometry/geometries/polyhedron.hpp Outdated Show resolved Hide resolved

vissarion reviewed Dec 29, 2020

View reviewed changes

barendgehrels requested changes Dec 30, 2020

View reviewed changes

barendgehrels requested review from awulkiew and mloskot December 30, 2020 09:34

Siddharth-coder13 requested review from barendgehrels and vissarion February 2, 2021 07:43

mloskot mentioned this pull request Feb 11, 2021

Fixed Writing 3D WKT:Z prefix #782

Open

Siddharth-coder13 added 6 commits February 14, 2021 16:57

Defined a geometry for polyhedron

00df0e5

Changed name from Polyhedron to PolyhedralSurface

617970d

Added prefix for PolyhedralSurface

09917a0

Fixed failed checks

2ee1f66

Fixed failed checks

f3355d8

Fixed failed checks

6db266c

Siddharth-coder13 added 2 commits February 14, 2021 16:57

Added polyhedral concept check

030d240

Added wkt read feature to polyhedral surfaces

b551f6d

Siddharth-coder13 force-pushed the 3d-geometries branch from 80442cb to b551f6d Compare February 14, 2021 11:35

Added wkt write feature for polyhedral surfaces

c1412c6

mloskot requested changes Feb 23, 2021

View reviewed changes

vissarion mentioned this pull request Feb 23, 2021

Convex Hull gives wrong output for 3D points. #683

Open

Added suggested changes

90b4c79

Siddharth-coder13 requested a review from mloskot February 23, 2021 12:57

barendgehrels requested changes Mar 3, 2021

View reviewed changes

Siddharth-coder13 added 2 commits March 24, 2021 21:52

Added suggested changes

d6b8e7c

Fixed identation

408ca8f

Siddharth-coder13 requested a review from barendgehrels April 3, 2021 04:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Defined a geometry for polyhedron #789

Defined a geometry for polyhedron #789

Siddharth-coder13 commented Dec 28, 2020

barendgehrels left a comment

Siddharth-coder13 commented Dec 29, 2020

vissarion left a comment

vissarion Dec 29, 2020

barendgehrels left a comment

Siddharth-coder13 commented Jan 6, 2021

barendgehrels commented Jan 7, 2021 •

edited

Loading

Siddharth-coder13 commented Feb 7, 2021

Siddharth-coder13 commented Feb 9, 2021

mloskot commented Feb 11, 2021

Siddharth-coder13 commented Feb 12, 2021

mloskot commented Feb 12, 2021

Siddharth-coder13 commented Feb 12, 2021 •

edited

Loading

mloskot commented Feb 12, 2021 •

edited

Loading

vissarion commented Feb 12, 2021

mloskot left a comment

Siddharth-coder13 commented Feb 27, 2021

Siddharth-coder13 commented Feb 27, 2021

barendgehrels commented Feb 27, 2021

mloskot commented Feb 27, 2021

barendgehrels left a comment

Siddharth-coder13 commented Mar 5, 2021

barendgehrels commented Mar 11, 2021

Siddharth-coder13 commented Apr 12, 2021

barendgehrels commented May 12, 2021

Siddharth-coder13 commented May 12, 2021

Defined a geometry for polyhedron #789

Are you sure you want to change the base?

Defined a geometry for polyhedron #789

Conversation

Siddharth-coder13 commented Dec 28, 2020

barendgehrels left a comment

Choose a reason for hiding this comment

Siddharth-coder13 commented Dec 29, 2020

vissarion left a comment

Choose a reason for hiding this comment

vissarion Dec 29, 2020

Choose a reason for hiding this comment

barendgehrels left a comment

Choose a reason for hiding this comment

Siddharth-coder13 commented Jan 6, 2021

barendgehrels commented Jan 7, 2021 • edited Loading

Siddharth-coder13 commented Feb 7, 2021

Siddharth-coder13 commented Feb 9, 2021

mloskot commented Feb 11, 2021

Siddharth-coder13 commented Feb 12, 2021

mloskot commented Feb 12, 2021

Siddharth-coder13 commented Feb 12, 2021 • edited Loading

mloskot commented Feb 12, 2021 • edited Loading

vissarion commented Feb 12, 2021

mloskot left a comment

Choose a reason for hiding this comment

Siddharth-coder13 commented Feb 27, 2021

Siddharth-coder13 commented Feb 27, 2021

barendgehrels commented Feb 27, 2021

mloskot commented Feb 27, 2021

barendgehrels left a comment

Choose a reason for hiding this comment

Siddharth-coder13 commented Mar 5, 2021

barendgehrels commented Mar 11, 2021

Siddharth-coder13 commented Apr 12, 2021

barendgehrels commented May 12, 2021

Siddharth-coder13 commented May 12, 2021

barendgehrels commented Jan 7, 2021 •

edited

Loading

Siddharth-coder13 commented Feb 12, 2021 •

edited

Loading

mloskot commented Feb 12, 2021 •

edited

Loading