Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TURNS] Disable start-turns, and take the closer point #589

Merged

Conversation

barendgehrels
Copy link
Collaborator

Closer point to measure distance, which makes that measurement more precise.

…tance,

which makes that measurement more precise.
@awulkiew
Copy link
Member

Is this PR needed in your future work on removing rescaling or is the intention fixing the issue #588? This PR does not fix it, the reason is something else (see in the issue). If this change is not needed and it interferes with your work I suggest to discard it.

@barendgehrels
Copy link
Collaborator Author

@awulkiew thanks for your investigations.
Though this PR does not fix the issue you reported, I'm still glad you mentioned it because it does solve issues in validity, when rescaling is turned off.
Because of that, and because of all issues are now fixed in another way, I currently don't need start-turns and would prefer if they are not necessary. Code wise (less code) and because of what you said, if I disable them in validity, the turns become context-dependent.

So I'm in favour of keeping this PR - but if you want to postpone it, so instead of disabling the code, removing it at all later (or keeping it in the end), that is also fine for me.

@awulkiew
Copy link
Member

but if you want to postpone it

If you prefer this solution than the other I'm ok with that. Less code is better than more code, etc.

@vissarion
Copy link
Member

Thanks. I am also ok if you want to merge this PR.

However, I do not see the less code argument. Is this a result of this PR or enables you to remove unnecessary code?

@barendgehrels
Copy link
Collaborator Author

About less code: it is indirectly a result of this PR because here we just disable start turns (without throwing away the code) and later I can either throw it away (preferred) or, if unfortunately necessary, re-enable it again but then I've also to distinguish between use cases (overlay-validation) without creating inconsistencies.

Thanks, I will merge it.

@barendgehrels barendgehrels merged commit af576e3 into boostorg:develop May 18, 2019
@barendgehrels barendgehrels deleted the bugfix/disable_start_turns branch May 18, 2019 16:16
@awulkiew awulkiew added this to the 1.71 milestone Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants