Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #1366
This is a big PR. Current stats:
85 files changed, 3955 insertions(+), 6767 deletions(-)
Fixes:
Summary:
Tests (as also reported earlier - but these are runs of today):
random_bitset_grids
:iterations: 100000 errors: 8 time: 48.776
iterations: 100000 errors: 0 time: 53.875
(better but still a bit slower, as reported in the discussion page)recursive_polygons_buffer
:geometries: 148743 errors: 307 type: d time: 8.806 (miter)
geometries: 149509 errors: 111 type: d time: 7.817 (miter)
round
it is different:geometries: 147743 errors: 518 type: d time: 8.541 (round)
geometries: 146474 errors: 762 type: d time: 7.875 (round)
robustness_recursive_polygons
geometries: 1269839 errors: 9 type: d time: 86.551
geometries: 1270000 errors: 0 type: d time: 92.921
- so a bit of regression here, should be investigatedSome things could not yet be fixed:
block_q
is used. There is a "concept fix" included (not active)