Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verify failures and remove some rescaling remainings #1353

Merged
merged 1 commit into from
Dec 9, 2024
Merged

test: verify failures and remove some rescaling remainings #1353

merged 1 commit into from
Dec 9, 2024

Conversation

barendgehrels
Copy link
Collaborator

This PR:

  • removes BoostGeometryWriteExpectedFailures (it was to compare rescaling with / without)
  • verifies failing tests
  • where not failing anymore, removes the defines or conditions

There were several tests which now succeeds. I didn't bisect them, but it is good to have them enabled now for future PR's.

@barendgehrels barendgehrels self-assigned this Dec 7, 2024
vissarion
vissarion approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@barendgehrels barendgehrels merged commit 54b300a into boostorg:develop Dec 9, 2024
23 checks passed
@barendgehrels barendgehrels deleted the test/verify-failures branch December 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vissarion vissarion vissarion approved these changes

@awulkiew awulkiew Awaiting requested review from awulkiew

Assignees

@barendgehrels barendgehrels

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barendgehrels @vissarion