Fix/issue 893 and 1299 #1347
Merged
Fix/issue 893 and 1299 #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
commented
Nov 24, 2024
barendgehrels
commented
Nov 24, 2024
barendgehrels
commented
Nov 24, 2024
barendgehrels
force-pushed
the
fix/issue-893-and-1299
branch
from
1ef4cae to
c5fe72b
Compare
barendgehrels
commented
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893 and #1299 which had the same cause.
This had to be tweaked for non-rescaling, there were some conditions not handled.