-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue #1326 and #1226 #1341
Merged
barendgehrels
merged 2 commits into
boostorg:develop
from
barendgehrels:fix/issue-1326-and-1226
Nov 16, 2024
Merged
Fix/issue #1326 and #1226 #1341
barendgehrels
merged 2 commits into
boostorg:develop
from
barendgehrels:fix/issue-1326-and-1226
Nov 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
2 times, most recently
from
November 14, 2024 21:20
7824944
to
c4b7e4d
Compare
barendgehrels
commented
Nov 14, 2024
include/boost/geometry/algorithms/detail/overlay/discard_duplicate_turns.hpp
Show resolved
Hide resolved
barendgehrels
commented
Nov 14, 2024
include/boost/geometry/algorithms/detail/overlay/discard_duplicate_turns.hpp
Show resolved
Hide resolved
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
from
November 14, 2024 21:28
c4b7e4d
to
414c464
Compare
barendgehrels
commented
Nov 14, 2024
barendgehrels
commented
Nov 14, 2024
barendgehrels
commented
Nov 15, 2024
include/boost/geometry/algorithms/detail/overlay/discard_duplicate_turns.hpp
Show resolved
Hide resolved
barendgehrels
commented
Nov 15, 2024
include/boost/geometry/algorithms/detail/overlay/discard_duplicate_turns.hpp
Outdated
Show resolved
Hide resolved
barendgehrels
commented
Nov 15, 2024
include/boost/geometry/algorithms/detail/overlay/discard_duplicate_turns.hpp
Show resolved
Hide resolved
vissarion
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the fixes!
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
from
November 15, 2024 18:13
414c464
to
8abb7ef
Compare
This can occur in a sequence of touch and then touch_interior
barendgehrels
force-pushed
the
fix/issue-1326-and-1226
branch
from
November 15, 2024 18:16
8abb7ef
to
07e418b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could occur in a sequence of touch and then touch_interior.
This PR fixes #1226 and #1326