Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/enhance tag casts #1325

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Feat/enhance tag casts #1325

merged 1 commit into from
Oct 9, 2024

Conversation

barendgehrels
Copy link
Collaborator

@barendgehrels barendgehrels commented Oct 7, 2024 •
edited
Loading

This PR:

  • uses tag_cast_t i/o tag_cast
  • where this happens, also uses tag_t
  • uses cs_tag_t i/o cs_tag
  • extracts single_tag_base_of to (renamed) a separate meta-function file primary_single_tag (I think it's more clear)

@barendgehrels barendgehrels self-assigned this Oct 7, 2024
@barendgehrels barendgehrels force-pushed the feat/enhance_tag_casts branch 3 times, most recently from bb92f3d to ce1c4c6 Compare October 7, 2024 18:44
@barendgehrels barendgehrels force-pushed the feat/enhance_tag_casts branch from ce1c4c6 to 18d86e8 Compare October 7, 2024 18:53
vissarion
vissarion approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@barendgehrels barendgehrels merged commit 8d2d399 into boostorg:develop Oct 9, 2024
23 checks passed
@barendgehrels barendgehrels deleted the feat/enhance_tag_casts branch December 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vissarion vissarion vissarion approved these changes

@awulkiew awulkiew Awaiting requested review from awulkiew

Assignees

@barendgehrels barendgehrels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barendgehrels @vissarion