-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Update qt example #1307
Conversation
@@ -34,6 +33,8 @@ | |||
#include "wx/dcgraph.h" | |||
#endif | |||
|
|||
#include "common/read_countries.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They now share code
5a9003e
to
bb8e480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
I managed to build and run in Ubuntu 22 (although not that straightforward ;)
First, Vulkan SDK was needed (see here).
Then I had several issues with qt local setup which I will not post here because it was probably due to my setup and not applicable to other users.
Something that should be mentioned in this PR is the dependency upgrade from qt4 to qt6. In particular, QT6.3 which introduces qt_standard_project_setup()
command. For example, ubuntu 22 has QT6.2.4 thus I replaced qt_standard_project_setup()
with
set(CMAKE_CXX_STANDARD 14)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTOUIC ON)
set(CMAKE_AUTORCC ON)
Thanks for testing! Will update the README and consult you |
BTW I could build it without vulcan. But also with |
bb8e480
to
e6cc1d8
Compare
@vissarion I updated the readme according to your findings. Is this OK? |
e6cc1d8
to
b5d4f91
Compare
That could be also possible in ubuntu, I didn't chech, I just show the warning and fix it by installing vulcan.
Thanks, I am OK! |
OK, I rephrase it a bit, adding "might", and merge, thanks! |
b5d4f91
to
a726a95
Compare
Recently I updated wxwidget example.
Similarly, this PR updates the qt example.
It's now simple to install on Mac, using brew
The first example
x01
was nearly the same as the otherx06
so the first is omitted.Example of running it.