Fix BOOST_GEOMETRY_CONSTEXPR call in index #1265
Conversation
| @@ -328,11 +328,11 @@ class insert | |||
| // Enlarge it in case if it's not bounding geometry type. | |||
| // It's because Points and Segments are compared WRT machine epsilon | |||
| // This ensures that leafs bounds correspond to the stored elements | |||
| if BOOST_GEOMETRY_CONSTEXPR (std::is_same<Element, value_type>::value | |||
| if (BOOST_GEOMETRY_CONSTEXPR ((std::is_same<Element, value_type>::value | |||
There was a problem hiding this comment.
Have you tested it with C++17?
My guess is that this would not compile because it'd expand to
if (constepxr ((...)))
The problem here is the comma. I think you only have to put std::is_same<Element, value_type>::value in parentheses.
There was a problem hiding this comment.
You are right, the problem is the first parenthesis, either putting std::is_same<Element, value_type>::value or the whole expression in parantheses is working, but I will follow your suggestion because it is simpler and focuses on the problem which is the comma. I will open a new PR.
There was a problem hiding this comment.
Do we want to add testing with C++17 on CI?
There was a problem hiding this comment.
Yes, I think it's a good idea. We have optional C++17-dependent code: inline variables, std::any adaptation, std::variant adaptation, if constexpr.
This PR fixes the compilation error
error: macro "BOOST_GEOMETRY_CONSTEXPR" passed 2 arguments, but takes just 1introduced by cb2f53d