Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test case for issue #1262 #1264

Merged

Conversation

barendgehrels
Copy link
Collaborator

No description provided.

@barendgehrels barendgehrels self-assigned this Mar 27, 2024
@@ -15,6 +15,8 @@
#ifndef BOOST_GEOMETRY_TEST_BUFFER_SVG_PER_TURN_HPP
#define BOOST_GEOMETRY_TEST_BUFFER_SVG_PER_TURN_HPP

#if defined(TEST_WITH_SVG_PER_TURN)
Copy link
Collaborator Author

@barendgehrels barendgehrels Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only needs to be compiled if this define is set.
Otherwise, #include <boost/ptr_container/ptr_vector.hpp> fails (if TEST_WITH_SVG is set) because ptr_vector is currently not in the CMakeLists and I don't want to add another dependency for this.

It's years ago I used this svg per turn, and I think it can be removed.

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@barendgehrels barendgehrels merged commit b8ac50f into boostorg:develop Apr 1, 2024
23 checks passed
@barendgehrels barendgehrels deleted the test/add-case-for-1262 branch December 14, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants