-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[util] move bounds to geometry::util #1254
Conversation
{ | ||
return boost::rational_cast<Target>(source); | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was placed here in last commit, but it is more consistent with other approach if it is all in rational.hpp
(it was there before as well)
Thanks, I think With that said. What do you think about removing it after rewriting or deprecating algorithms using Btw, C++14 has this: https://en.cppreference.com/w/cpp/language/attributes/deprecated |
Didn't answer this yet. But yes, it makes sense. We use it in some places, but not often. And yes, assign_inverse we can deprecate, I forgot it, but I guess it was mainly for spherical/geographic |
There was one comment but I don't think it will change the PR. |
lgtm thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
This is a follow up on
numeric_cast
- now forbounds
- which is different and simpler because it was already a structure.It also adds unit tests for it.
So
bounds
for Boost.Rational was stil necessary.It also adds
CMakeLists.txt
for the folders which tests which were affected