Fixes compile error in tests and add removed tests for is_simple and is_valid #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vissarion
changed the title
| BOOST_CHECK_CLOSE(bg::detail::numeric_cast<double>(r2), 2.5, 0.00001); | ||
| BOOST_CHECK_EQUAL(bg::detail::numeric_cast<int>(r2), 2); | ||
| BOOST_CHECK_CLOSE(bg::util::numeric_cast<double>(r2), 2.5, 0.00001); | ||
| BOOST_CHECK_EQUAL(bg::util::numeric_cast<int>(r2), 2); |
There was a problem hiding this comment.
Oops. As soon as the Cmake PR is merged ,this won't happen anymore ;-)
Thanks for fixing.
There was a problem hiding this comment.
I see it was just approved, thanks, it's merged now
…ordinates are close to the maximum double
vissarion
force-pushed
the
fix/test_nan
branch
from
b429867 to
d76ce3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following comment #1237 (comment) this PR adds removed tests for is_simple and is_valid with geometries whose coordinates are close to the maximum double.
The tests are passing with the fix of #1237 but the results are different i.e. the intersection does not create NaN coordinates, it is more accurate but still can create invalid geometries.
This PR also fixes a compile error in tests (wrong namespace for numeric_cast).