Remove deprecated test-suite rule #1215
Conversation
According to bfgroup/b2@5973506, b2 deprecated test-suite rule in 2007.
There was a problem hiding this comment.
Thanks for this PR!
test-suite is deprecated indeed but it should be replaced by an equivalent rule i.e. alias instead of removing it.
If you removed it then the user would no longer be able to run commands of the form
b2 test/algorithms/area//boost-geometry-algorithms-area
|
Thanks for the review. The reason why I remove it instead of replacing with Well, it's not that important. If you still think |
|
I agree that there is a workaround for calling all tests in a directory but it seems like a braking change. Also I am not sure that the commands in the circleCI script will be run after this change. Cf. https://github.com/boostorg/geometry/blob/develop/.circleci/config.yml#L77C74-L77C116 |
|
Sorry for my carelessness. It is a breaking change at least for CI. |
| run is_valid_geo.cpp : : : : algorithms_is_valid_geo ; | ||
| run is_valid.cpp : : : <define>BOOST_GEOMETRY_ROBUSTNESS_ALTERNATIVE : algorithms_is_valid_alternative ; | ||
| run is_valid_failure.cpp : : : <define>BOOST_GEOMETRY_ROBUSTNESS_ALTERNATIVE : algorithms_is_valid_failure_alternative ; | ||
| run is_valid_geo.cpp : : : <define>BOOST_GEOMETRY_ROBUSTNESS_ALTERNATIVE : algorithms_is_valid_geo_alternative ; |
There was a problem hiding this comment.
In the meantime, this is gone and should be omitted.
What are the plans with this PR?
According to
bfgroup/b2@5973506, b2 deprecated test-suite rule in 2007.