Switch to boost::core::invoke_swap. Add missing includes.
#1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boost::swap is deprecated and will be removed. Use boost::core::invoke_swap as a replacement. Also add missing includes.
barendgehrels
approved these changes
Sep 5, 2023
| swap(result.geodesic_scale, M21); | ||
| boost::core::invoke_swap(sin_alpha1, sin_alpha2); | ||
| boost::core::invoke_swap(cos_alpha1, cos_alpha2); | ||
| boost::core::invoke_swap(result.geodesic_scale, M21); |
There was a problem hiding this comment.
We can, if I see it correctly, replace these calls (here) with just std::swap
And maybe on more places.
But for now this PR looks okay to me.
vissarion
approved these changes
Sep 8, 2023
|
The test failures show that some Boost.Geometry headers are incomplete and probably broken. I didn't know how to fix it, and it wasn't the point of this PR anyway. For example, this seems to rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boost::swapis deprecated and will be removed. Useboost::core::invoke_swapas a replacement.Also add missing includes.