feat(ranking-api): ranking api 부분 완성 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimkim
commented
Feb 10, 2024
Comment on lines
+1
to
+2
| export const isNil = (value: any): value is null | undefined => | ||
| value === null || value === undefined; |
There was a problem hiding this comment.
멘토님의 조언을 받아 isNil 생성
vimkim
commented
Feb 10, 2024
Comment on lines
+1
to
+5
| export interface RankingResponseDto { | ||
| username: string; | ||
| numberOfProblemsSolved: number; | ||
| mostRecentCorrectSubmissionTime: string; | ||
| } |
There was a problem hiding this comment.
합의한 Ranking Dto 추가. 현재 쓰는 것은 username 뿐입니다.
vimkim
commented
Feb 10, 2024
Comment on lines
+32
to
+33
| @Inject(forwardRef(() => SubmissionService)) | ||
| private readonly submissionService: SubmissionService, |
There was a problem hiding this comment.
Room <-> Submission 간 상호 의존 추후 수정 예정
vimkim
commented
Feb 10, 2024
Comment on lines
30
to
+38
| } | ||
| @Get('ranking') | ||
| async getRanking( | ||
| @Query() roomSubmissionDto: RoomSubmissionDto, | ||
| ): Promise<RankingResponseDto[]> { | ||
| return this.submissionService.getUsersRankingByRoomCode( | ||
| roomSubmissionDto.roomCode, | ||
| ); | ||
| } |
There was a problem hiding this comment.
기존에 합의한 /room/:code/ranking api가 현재 nest js dependency injection 의 한계로 submission에 들어와 있습니다. 추후 수정 예정..
vimkim
commented
Feb 10, 2024
Comment on lines
130
to
135
| allSubmissions.each((index, element) => { | ||
| const { tmpBojSolutionId, tmpStatus } = this.getEachSubmissionInfo( | ||
| $, | ||
| element, | ||
| ); | ||
| const { tmpBojSolutionId, tmpStatus: unknownStatus } = | ||
| this.getEachSubmissionInfo($, element); | ||
|
|
||
| const tmpStatus = unknownStatus as keyof typeof BojResultsToStatus; | ||
|
|
vimkim
commented
Feb 10, 2024
Comment on lines
+198
to
+217
| async getSubmissionsByRoomCodeGroupByUsers( | ||
| roomCode: string, | ||
| ): Promise<RankingResponseDto[]> { | ||
| const qb = this.submissionRepository | ||
| .createQueryBuilder('s') | ||
| .innerJoin('s.room', 'r', 'r.code = :roomCode', { roomCode }) | ||
| .innerJoin('s.user', 'u') | ||
| .where('s.status = :status', { status: Status.ACCEPTED }) | ||
| .addSelect('u.username', 'username') | ||
| .addSelect('COUNT(*)', 'numberOfProblemsSolved') | ||
| .addSelect('MAX(s.submittedAt)', 'mostRecentCorrectSubmissionTime'); | ||
|
|
||
| this.explainQuery(...qb.getQueryAndParameters()); | ||
|
|
||
| const results = await qb.getRawMany(); | ||
| results.forEach((res) => { | ||
| res.numberOfProblemsSolved = Number(res.numberOfProblemsSolved); | ||
| }); | ||
| return results; | ||
| } |
There was a problem hiding this comment.
첫번째 쿼리. 오류가 있어서 추후 수정 후 성능 비교 예정
vimkim
commented
Feb 10, 2024
Comment on lines
+219
to
+229
| async getUsersRankingByRoomCode(code: string): Promise<RankingResponseDto[]> { | ||
| const qb = this.entityManager | ||
| .createQueryBuilder(Room, 'room') | ||
| .where('room.code = :code', { code }) | ||
| .select('user.username', 'username') | ||
| .addSelect('COUNT(*)', 'numberOfProblemsSolved') | ||
| .addSelect( | ||
| 'MAX(submission.submittedAt)', | ||
| 'mostRecentCorrectSubmissionTime', | ||
| ) | ||
| .innerJoin('room.joinedUsers', 'roomUser') |
There was a problem hiding this comment.
두번째 쿼리, 예상대로 잘 동작하지만 조금 버그가 있어 디비 손 볼 예정
vimkim
commented
Feb 10, 2024
Comment on lines
+4
to
+7
| "moduleNameMapper": { | ||
| "src/(.*)$": "<rootDir>/../src/$1", | ||
| "test/(.*)$": "<rootDir>/$1" | ||
| }, |
There was a problem hiding this comment.
jest를 baseDir 설정과 같이 돌리기 위한 설정
vimkim
changed the title
vimkim
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e 테스트를 추가하려다, 풀리퀘가 너무 길어질 것을 우려해서 우선 부분적으로 동작하는지만 확인하고,
추후 새로운 브랜치에서 e2e를 완성하고,
이후 다시 돌아와 보완할 계획입니다.